Skip to content

Fix lints #7109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix lints #7109

wants to merge 1 commit into from

Conversation

mergennachin
Copy link
Contributor

@mergennachin mergennachin commented Nov 27, 2024 •
edited
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 27, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7109

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 16ff7a0 with merge base d136206 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 27, 2024
@mcremon-meta
Copy link
Contributor

thanks @mergennachin, seems like the linter is still failing :( @zonglinpeng not sure if you had that PR opened yet

davidlin54
davidlin54 approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@davidlin54 davidlin54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing, I also put up #7110 before I saw this, which also fixes 2 other lints

@mergennachin mergennachin deleted the fix_lints branch January 27, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlin54 davidlin54 davidlin54 approved these changes

@mcremon-meta mcremon-meta mcremon-meta approved these changes

@tarun292 tarun292 Awaiting requested review from tarun292

@zonglinpeng zonglinpeng Awaiting requested review from zonglinpeng

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mergennachin @mcremon-meta @davidlin54 @facebook-github-bot